Fix RandomStringUtils.random bounds validation #1523
+32
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where start/end were not strictly validated when chars is not null, potentially causing IndexOutOfBoundsException.
ThrawnCA
reviewed
Jan 5, 2026
| throw new IllegalArgumentException("The chars array must not be empty"); | ||
| } | ||
|
|
||
| if (chars!=null) { |
Contributor
There was a problem hiding this comment.
Lots of missing spaces in this code block. There should be spaces before and after operators, as per the style used in the rest of this file, eg this line should be if (chars != null) {
ThrawnCA
reviewed
Jan 5, 2026
| final Random random = new Random(); | ||
| IllegalArgumentException ex; | ||
|
|
||
| ex=assertThrows(IllegalArgumentException.class, () -> |
Contributor
There was a problem hiding this comment.
Missing spaces before and after operators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where start/end were not strictly validated when chars is not null, potentially causing IndexOutOfBoundsException.
Thanks for your contribution to Apache Commons! Your help is appreciated!
Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.